compiletest: rename `add-core-stubs`/`core-stubs-compile-flags` to `add-minicore`/`minicore-compile-flags` #148305

RalfJung · 2025-10-30T16:34:40Z

rustbot · 2025-10-30T16:34:44Z

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

Some changes occurred in tests/codegen-llvm/stack-probes-inline.rs

cc @rust-lang/project-exploit-mitigations, @rcvalle

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

Some changes occurred in tests/codegen-llvm/sanitizer

cc @rcvalle

Some changes occurred in tests/ui/sanitizer

cc @rcvalle

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2025-10-30T16:34:47Z

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

wesleywiser

Looks good to me but I'll let @jieyouxu review as well before r+'ing

View changes since this review

tests/codegen-llvm/abi-win64-zst.rs

tests/ui/target-feature/tied-features.rs

jieyouxu

Thanks, one nit, you can r=Wesley and me after.

View changes since this review

tests/ui/cmse-nonsecure/cmse-nonsecure-entry/return-via-stack.rs

tests/ui/panic-runtime/need-immediate-abort-got-abort.rs

jieyouxu · 2025-11-01T08:47:10Z

@bors p=10 (logically conflict-prone)

jieyouxu · 2025-11-01T08:47:32Z

@bors rollup=never (logically conflict-prone)

jieyouxu · 2025-11-01T08:47:52Z

@rustbot author

RalfJung · 2025-11-02T09:43:32Z

I'm happy to also do that rename here.

RalfJung · 2025-11-02T09:45:36Z

@rustbot ready

jieyouxu · 2025-11-02T09:48:53Z

I'm happy to also do that rename here.

If you are up for that, I think it might be better to just do that in this PR, otherwise we'd have this weird transitional phase where the main directive is called add-minicore but the flag directive is called core-stubs-compile-flags. I'd be happy to review that.

bors · 2025-11-02T15:29:09Z

⌛ Testing commit 97d8f3e with merge 2c903f2...

compiletest: rename `add-core-stubs`/`core-stubs-compile-flags` to `add-minicore`/`minicore-compile-flags` Fixes #148282

rust-log-analyzer · 2025-11-02T16:14:27Z

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- fs::tests::metadata_access_times stdout ----

thread 'fs::tests::metadata_access_times' (250955) panicked at library/std/src/fs/tests.rs:1737:33:
assertion failed: t1 <= t2
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::panicking::panic
   3: core::ops::function::FnOnce::call_once

bors · 2025-11-02T16:14:27Z

💔 Test failed - checks-actions

RalfJung · 2025-11-02T18:00:09Z

I... didn't change that code?
@bors retry

bors · 2025-11-02T19:43:31Z

⌛ Testing commit 97d8f3e with merge b15a874...

bors · 2025-11-02T23:11:18Z

☀️ Test successful - checks-actions
Approved by: jieyouxu,wesleywiser
Pushing b15a874 to master...

github-actions · 2025-11-02T23:14:25Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8483293 (parent) -> b15a874 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b15a874aafe7eab9ea3ac2c1d59c7b03e1425027 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-gnu-llvm-20-2: 2503.0s -> 2150.0s (-14.1%)
x86_64-rust-for-linux: 3099.3s -> 2692.7s (-13.1%)
i686-gnu-2: 6249.0s -> 5435.5s (-13.0%)
x86_64-gnu-debug: 7145.3s -> 6265.6s (-12.3%)
pr-check-2: 2631.0s -> 2314.3s (-12.0%)
x86_64-gnu-llvm-20-2: 6264.4s -> 5516.0s (-11.9%)
x86_64-gnu-miri: 5000.2s -> 4420.4s (-11.6%)
i686-msvc-1: 9459.9s -> 10519.5s (+11.2%)
i686-gnu-1: 8360.1s -> 7428.8s (-11.1%)
x86_64-gnu-gcc: 3477.6s -> 3099.9s (-10.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-03T00:21:40Z

Finished benchmarking commit (b15a874): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.1%	[3.1%, 3.1%]	1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.0%	[3.0%, 3.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.0%	[3.0%, 3.0%]	1

Binary size

Results (primary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[1.1%, 1.1%]	1

Bootstrap: 473.503s -> 473.039s (-0.10%)
Artifact size: 390.87 MiB -> 390.80 MiB (-0.02%)

Kobzol · 2025-11-03T20:47:58Z

Noise, this only changed tests.

@rustbot label: +perf-regression-triaged

rustbot assigned wesleywiser Oct 30, 2025

jieyouxu self-assigned this Oct 30, 2025

Urgau mentioned this pull request Oct 30, 2025

Tracking issue for MCP 930: Rename //@ add-core-stubs to //@ add-minicore #148282

Closed

5 tasks

wesleywiser approved these changes Oct 30, 2025

View reviewed changes

tests/codegen-llvm/abi-win64-zst.rs Outdated Show resolved Hide resolved

tests/ui/target-feature/tied-features.rs Outdated Show resolved Hide resolved

RalfJung force-pushed the add-minicore branch from 25efd5e to 02369a3 Compare October 30, 2025 18:54

This comment has been minimized.

Sign in to view

RalfJung force-pushed the add-minicore branch from 02369a3 to 5dc60fb Compare October 30, 2025 19:43

jieyouxu approved these changes Nov 1, 2025

View reviewed changes

tests/ui/cmse-nonsecure/cmse-nonsecure-entry/return-via-stack.rs Outdated Show resolved Hide resolved

tests/ui/panic-runtime/need-immediate-abort-got-abort.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2025

RalfJung force-pushed the add-minicore branch from 5dc60fb to 0347eae Compare November 2, 2025 09:45

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 2, 2025

This comment has been minimized.

Sign in to view

RalfJung force-pushed the add-minicore branch from 0347eae to e6f0ef0 Compare November 2, 2025 10:14

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 2, 2025

bors added a commit that referenced this pull request Nov 2, 2025

Auto merge of #148305 - RalfJung:add-minicore, r=jieyouxu,wesleywiser

2c903f2

compiletest: rename `add-core-stubs`/`core-stubs-compile-flags` to `add-minicore`/`minicore-compile-flags` Fixes #148282

matthiaskrgr mentioned this pull request Nov 2, 2025

Rollup of 9 pull requests #148404

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 2, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2025

RalfJung mentioned this pull request Nov 2, 2025

Spurious test failure in metadata_access_times #148408

Open

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 2, 2025

bors merged commit b15a874 into rust-lang:master Nov 2, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 2, 2025

bors mentioned this pull request Nov 3, 2025

Stabilize -Zno-jump-tables into -Cjump-tables=bool #145974

Merged

2 tasks

rustbot added the perf-regression Performance regression. label Nov 3, 2025

rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 3, 2025

This was referenced Nov 4, 2025

Make named asm_labels lint not trigger on hexagon register spans #143037

Merged

Add #[rustc_pass_indirectly_in_non_rustic_abis] #144529

Merged

RalfJung deleted the add-minicore branch November 4, 2025 07:10

compiletest: rename add-core-stubs/core-stubs-compile-flags to add-minicore/minicore-compile-flags #148305

compiletest: rename add-core-stubs/core-stubs-compile-flags to add-minicore/minicore-compile-flags #148305

Uh oh!

Conversation

RalfJung commented Oct 30, 2025

Uh oh!

rustbot commented Oct 30, 2025

Uh oh!

rustbot commented Oct 30, 2025

Uh oh!

wesleywiser left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

jieyouxu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented Nov 1, 2025

Uh oh!

jieyouxu commented Nov 1, 2025

Uh oh!

RalfJung commented Nov 2, 2025

Uh oh!

RalfJung commented Nov 2, 2025

Uh oh!

jieyouxu commented Nov 2, 2025

Uh oh!

This comment has been minimized.

bors commented Nov 2, 2025

Uh oh!

rust-log-analyzer commented Nov 2, 2025

Uh oh!

bors commented Nov 2, 2025

Uh oh!

RalfJung commented Nov 2, 2025

Uh oh!

bors commented Nov 2, 2025

Uh oh!

bors commented Nov 2, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 2, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Nov 3, 2025

Overall result: ❌ regressions - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Kobzol commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

compiletest: rename `add-core-stubs`/`core-stubs-compile-flags` to `add-minicore`/`minicore-compile-flags` #148305

compiletest: rename `add-core-stubs`/`core-stubs-compile-flags` to `add-minicore`/`minicore-compile-flags` #148305

wesleywiser left a comment •

edited by rustbot

Loading

jieyouxu left a comment •

edited

Loading

jieyouxu commented Nov 1, 2025 •

edited

Loading